Do not cache PID or process name #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
force-pushed
the
pid
branch
2 times, most recently
from
51b4253
to
4d2e161
Compare
dmlloyd
added a commit
to dmlloyd/jboss-logmanager
that referenced
this pull request
Apr 3, 2024
See smallrye/smallrye-common#299. Prevents caching of process ID across native image (where the PID may change).
dmlloyd
added a commit
to dmlloyd/jboss-logmanager
that referenced
this pull request
Apr 3, 2024
See smallrye/smallrye-common#299. Prevents caching of process ID across native image (where the PID may change).
dmlloyd
added a commit
to dmlloyd/jboss-logmanager
that referenced
this pull request
Apr 3, 2024
See smallrye/smallrye-common#299. Prevents caching of process ID across native image (where the PID may change).
Also simplify the computation of process name, and deprecate these methods in favor of the far superior `ProcessHandle` API.
dmlloyd
added a commit
to dmlloyd/jboss-logmanager
that referenced
this pull request
Apr 3, 2024
See smallrye/smallrye-common#299. Prevents caching of process ID across native image (where the PID may change).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify the computation of process name, and deprecate these methods in favor of the far superior
ProcessHandleAPI.