Fixes #13: Injection of Provider #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use default values for injected collection if the property is not configured. * add testsuite/extra module to provide tests in addition to the ones from the MicroProfile Config TCK * add CollectionWithConfiguredValueTest & CollectionWithDefaultValueTest to verify the expected behaviour * move tck module under testsuite
This aligns their behaviour with primitive array. However, MicroProfile Config specification is not clear on this behaviour and there is discussion about it at eclipse/microprofile-config#376 This fix ensures at least a consistent behaviour between primitive arrays and Collections.
Fix injection of Provider to return a value lazily evaluated. Add ProviderTest to verify the behaviour Issue: smallrye#13
jmesnil
force-pushed
the
13_injected_Provider
branch
from
f079119
to
fd28a6b
Compare
kenfinnigan
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix injection of Provider to return a value lazily evaluated.
Add ProviderTest to verify the behaviour
Issue: #13