Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate thread pool style bulkhead with event loop #404

Closed
Ladicek opened this issue Apr 29, 2021 · 0 comments · Fixed by #419
Closed

integrate thread pool style bulkhead with event loop #404

Ladicek opened this issue Apr 29, 2021 · 0 comments · Fixed by #419
Assignees
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Apr 29, 2021

Currently, our implementation of thread pool style bulkhead for async/nonblocking methods (CompletionStageBulkhead) maintains a queue of tasks. Tasks are picked up from this queue when currently executing tasks finish. This means that tasks are executed on unknown threads. This is not OK when the original task submission happened on an event loop. Such tasks should always be executed on the original event loop.

We have to expand the event loop abstraction to cover this use case.

@Ladicek Ladicek self-assigned this May 12, 2021
@Ladicek Ladicek added this to the 5.0.1 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant