bulkhead event loop integration #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
force-pushed
the
bulkhead-event-loop-integration
branch
from
01670f7
to
4220366
Compare
This commit includes a significant refactoring of the event loop integration API. This would normally be a breaking change, but the event loop integration API is private, and isn't yet present in any release, so it's OK. The event loop is now required to provide a `Scheduler` (instead of _being_ a `Scheduler`), as well as an `Executor`. The `Scheduler` is used for retries, while the `Executor` is used for running queued bulkhead tasks.
This commit removes the `MainScheduler` class, which used to check the current thread right before scheduling the invocation. Instead, we now remember the event loop scheduler eagerly, if the invocation thread is an event loop thread, and later just use it. This is close to how an event loop executor is remembered for non-blocking method invocations in `CompletionStageExecution`. At the same time, the `VertxScheduler` implementation is improved to always schedule tasks on the correct event loop thread, in case there are multiple.
Ladicek
force-pushed
the
bulkhead-event-loop-integration
branch
from
4220366
to
93877f8
Compare
With this commit, we no longer use an event loop for task scheduling. Instead, we always use our `Timer` for scheduling, and only use an event loop for task execution (using `Executor`). If we have to schedule a task for execution on an event loop, we create another task that executes the original on an event loop, and schedule that. The primary motivation is to avoid having to implement a scheduler on top of an event loop if we already have a decent one, but there's another motive as well: the Vert.x timer, which we used to implement the Vert.x scheduler, is rather inaccurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404