Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute a multi-release jar #420

Closed
bstansberry opened this issue May 16, 2021 · 4 comments · Fixed by #409
Closed

Distribute a multi-release jar #420

bstansberry opened this issue May 16, 2021 · 4 comments · Fixed by #409
Milestone

Comments

@bstansberry
Copy link

The code includes multi-release source (https://github.com/smallrye/smallrye-fault-tolerance/tree/main/implementation/fault-tolerance/src/main/java9) but the 5.0.0 zip on maven central does not include it.

The result is when I try and test smallrye FT on WildFly with SE 16 or later I get:

java.lang.reflect.InaccessibleObjectException: Unable to make java.lang.invoke.MethodHandles$Lookup(java.lang.Class) accessible: module java.base does not "opens java.lang.invoke" to unnamed module @35f1d892
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:357)
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
	at java.base/java.lang.reflect.Constructor.checkCanSetAccessible(Constructor.java:188)
	at java.base/java.lang.reflect.Constructor.setAccessible(Constructor.java:181)
	at io.smallrye.fault-tolerance//io.smallrye.faulttolerance.DefaultMethodFallbackProvider.getFallback(DefaultMethodFallbackProvider.java:19)

WF is going to have to add some --add-opens to run on SE 16+ but it would be good to not need this one.

@Ladicek
Copy link
Contributor

Ladicek commented May 17, 2021

This is fixed in #409, which will be part of 5.1.0.

@Ladicek Ladicek added this to the 5.1.0 milestone May 17, 2021
@Ladicek Ladicek linked a pull request May 17, 2021 that will close this issue
@Ladicek Ladicek closed this as completed May 17, 2021
@bstansberry
Copy link
Author

Thanks, Ladicek!

@Ladicek
Copy link
Contributor

Ladicek commented May 19, 2021

FYI 5.1.0 was released yesterday (also CC @rhusar).

@rhusar
Copy link
Contributor

rhusar commented May 19, 2021

@Ladicek Thanks, PR is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants