Update to OpenTracing 0.33 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
previously approved these changes
Jan 14, 2021
Ladicek
force-pushed
the
opentracing-0.33
branch
from
bef65f6
to
93ff5fc
Compare
Ladicek
commented
Jan 15, 2021
| return () -> { | ||
| Scope propagated = scopeManager.activate(span, false); | ||
| Scope propagated = scopeManager.activate(span); | ||
| return propagated::close; | ||
| }; | ||
| } |
There was a problem hiding this comment.
I'm looking at this again and I found this a bit weird. If the original thread had an active span, but not an active scope, the new thread will have the same active span, but it will also have an active scope.
I have read through opentracing/opentracing-java#267 and opentracing/opentracing-java#291 and it seems to me that OpenTracing just actively fights against our progamming model :-)
But I guess there's nothing better that we could do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.