-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How I'm supposed to add errors to the response in an EventingServices #2107
Comments
Two options come to my mind (and we could do both):
I think option 1) could have a bigger impact in the long run, and 2) seems the minimum we should do. |
|
At that point, the ExecutionResult is already built and immutable and besides, it wouldn't seem proper to override results for particular fields by replacing them with an error. An error thrown in an |
Shouldn't the ExecutionResult only be built after the |
Ok I'm checking it and... it seems that it is possible to overwrite the execution result by casting the We could change that line to re-retrieve the Would that be ok for you? |
Yeah I guess that would work too. |
close? |
I have the case where the
afterExecute
of my custom EventingService may throw an error and it is impossible to add this errorto the
ExecutionResult
. Only option is to throw an Exception which is not catched and handled anywhere and leads to an 500 error.The text was updated successfully, but these errors were encountered: