Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to access recoverWith() without providing a timeout #28

Closed
kenfinnigan opened this issue Sep 10, 2019 · 1 comment · Fixed by #43
Closed

Able to access recoverWith() without providing a timeout #28

kenfinnigan opened this issue Sep 10, 2019 · 1 comment · Fixed by #43
Labels
bug Something isn't working
Milestone
0.1.1

Comments

@kenfinnigan
Copy link
Collaborator

It's possible to do:

uni.onNoItem().recoverWithItem(defaultValue)

without having set a timeout. However, the code then fails because a timeout isn't set
@kenfinnigan kenfinnigan added the bug Something isn't working label Sep 10, 2019
@cescoffier
Copy link
Contributor

An intermediate group is required to avoid have access to the method without the timeout.

cescoffier added a commit that referenced this issue Dec 10, 2019
@cescoffier
Fix #28 - introduce an intermediary group to avoid using recovery met…
1cfd1bb 
…hods without timeout.
@cescoffier cescoffier mentioned this issue Dec 10, 2019
Merged
cescoffier added a commit that referenced this issue Dec 10, 2019
@cescoffier
Merge pull request #43 from smallrye/features/fix-28-recoverWith-must…
b978df0 
…HAveTimeout

Fix #28 - It should not be possible to not set the timeout
@cescoffier cescoffier added this to the 0.2.0 milestone Dec 10, 2019
@cescoffier cescoffier modified the milestones: 0.2.0, 0.1.1 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

Fix #28 - It should not be possible to not set the timeout smallrye/smallrye-mutiny
2 participants
@cescoffier @kenfinnigan