Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recoverWithNull() and replaceWithNull() #317

Closed
gavinking opened this issue Oct 3, 2020 · 3 comments · Fixed by #324
Closed

recoverWithNull() and replaceWithNull() #317

gavinking opened this issue Oct 3, 2020 · 3 comments · Fixed by #324
Assignees
Labels
on-roadmap The issue is part of the roadmap
Milestone

Comments

@gavinking
Copy link

Due to overloading, UniOnFailure.recoverWithItem(null) and Uni.replaceWith(null) result in compilation errors, forcing me to write either recoverWithItem((Void) null) or recoverWithItem(()->null).

I would like to request new methods to make it easy to obtain a Uni<Void>. If recoverWithNull() and replaceWithNull() seem too verbose, they could be named recover() and discard().

@cescoffier cescoffier added the on-roadmap The issue is part of the roadmap label Oct 4, 2020
@cescoffier
Copy link
Contributor

I like recoverWithNull() and replaceWithNull(), the names convey what it does.

@cescoffier cescoffier added this to the 0.10.0 milestone Oct 5, 2020
@jponge jponge self-assigned this Oct 5, 2020
@jponge
Copy link
Member

jponge commented Oct 5, 2020

I will do

@jponge
Copy link
Member

jponge commented Oct 6, 2020

See #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-roadmap The issue is part of the roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants