Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report concurrent onNext signals in HalfSerializer #1144

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Report concurrent onNext signals in HalfSerializer #1144

merged 1 commit into from
Dec 8, 2022

Conversation

jponge
Copy link
Member

@jponge jponge commented Dec 8, 2022

Such concurrent signals are a violation of the Reactive Streams protocol.

Such concurrent signals are a violation of the Reactive Streams protocol.
@jponge jponge added bug Something isn't working backport PR that shall be back-ported labels Dec 8, 2022
@jponge jponge added this to the 2.0.1 milestone Dec 8, 2022
@jponge jponge added this to In progress in Mutiny development via automation Dec 8, 2022
@jponge jponge added this to Pending in 1.x backports via automation Dec 8, 2022
@jponge jponge linked an issue Dec 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1144 (b621789) into main (2042453) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1144      +/-   ##
============================================
+ Coverage     89.68%   89.76%   +0.07%     
  Complexity     3348     3348              
============================================
  Files           458      458              
  Lines         13224    13227       +3     
  Branches       1646     1646              
============================================
+ Hits          11860    11873      +13     
+ Misses          709      699      -10     
  Partials        655      655              
Impacted Files Coverage Δ
...ava/io/smallrye/mutiny/helpers/HalfSerializer.java 80.95% <100.00%> (-7.94%) ⬇️
...erators/multi/builders/SerializedMultiEmitter.java 79.26% <0.00%> (-6.10%) ⬇️
...mallrye/mutiny/operators/multi/FlatMapManager.java 95.83% <0.00%> (-2.78%) ⬇️
...ny/operators/uni/builders/UniCreateFromFuture.java 88.52% <0.00%> (-1.64%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 89.36% <0.00%> (-1.00%) ⬇️
...a/io/smallrye/mutiny/helpers/BlockingIterable.java 86.11% <0.00%> (-0.93%) ⬇️
...lrye/mutiny/subscription/SerializedSubscriber.java 86.23% <0.00%> (+0.91%) ⬆️
...subscription/SwitchableSubscriptionSubscriber.java 95.23% <0.00%> (+1.58%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 81.76% <0.00%> (+1.65%) ⬆️
... and 5 more

Mutiny development automation moved this from In progress to Reviewer approved Dec 8, 2022
@jponge jponge merged commit b446bf7 into main Dec 8, 2022
@jponge jponge deleted the bug/1141 branch December 8, 2022 16:28
Mutiny development automation moved this from Reviewer approved to Done Dec 8, 2022
@jponge jponge moved this from Pending to 1.9.0 in 1.x backports Dec 8, 2022
@jponge jponge modified the milestones: 2.0.1, 2.1.0 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR that shall be back-ported bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

HalfSerializer drops items silently
2 participants