Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expireAt/expireIn to back off retry #171

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

pcasaes
Copy link
Contributor

@pcasaes pcasaes commented Jun 16, 2020

When using exponential back during Uni/Multi retry we must specify a max retry attempts. With these two methods we will be able to specify an expiration time instead.

When using exponential back during Uni/Multi retry we must specify a max retry attempts. With these two methods we will be able to specify an expiration time instead.
@pcasaes
Copy link
Contributor Author

pcasaes commented Jun 17, 2020

Hello @cescoffier
I was hoping to get your attention on this one.

@cescoffier
Copy link
Contributor

Don’t worry. I will review it.

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@cescoffier cescoffier added this to the 0.6.0 milestone Jun 17, 2020
@cescoffier cescoffier added the enhancement New feature or request label Jun 17, 2020
@cescoffier cescoffier merged commit 09e7281 into smallrye:master Jun 17, 2020
@cescoffier cescoffier modified the milestones: 0.6.0, 0.5.3 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants