Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uni.onFailure().invoke should enforce the failure predicate #187

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Uni.onFailure().invoke should enforce the failure predicate #187

merged 1 commit into from
Jun 24, 2020

Conversation

cescoffier
Copy link
Contributor

Fix #186.

Uni.onFailure().invoke should enforce the predicate checking the failure.
The commit also adds the missing Javadoc to the UniOnFailure and MultiOnFailure.

@cescoffier
Fix #186
9183400 
Uni.onFailure().invoke should enforce the predicate checking the failure.

The commit also adds the missing javadoc to the UniOnFailure and MultiOnFailure.
@cescoffier cescoffier added the bug Something isn't working label Jun 24, 2020
@cescoffier cescoffier added this to the 0.6.0 milestone Jun 24, 2020
@cescoffier cescoffier merged commit 8e4b31e into master Jun 24, 2020
@cescoffier cescoffier deleted the features/186-fix-on-failure-invoke-predicate branch June 24, 2020 15:23
@cescoffier cescoffier modified the milestones: 0.6.0, 0.5.4 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenfinnigan kenfinnigan kenfinnigan approved these changes

@jponge jponge Awaiting requested review from jponge

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.4
Development

Successfully merging this pull request may close these issues.

onFailure(..).invoke always called no matter onFailure arguments
2 participants
@cescoffier @kenfinnigan