Improve CompositeException to override getCause() #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally). It also checks that at least one exception is passed. It might be interested later to use suppressed exceptions.
|
LGTM |
|
Would it make sense to use suppressed exceptions for aggregating multiple exceptions? |
|
There are 2 cases, in one suppressed makes sense, but less in the other case. If you have a failure and you react on it triggering another (unfortunate) failure, suppressed makes sense in this case. There is a "root" failure and another suppressed one. In the other case, you have multiple failures coming from different Uni/Multi, like in a combined operation. In this case, there are no root failures, they are just a group of failures. |
cescoffier
deleted the
features/composite-exception-should-override-getCause
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve CompositeException to override getCause (which was null initially).
It also checks that at least one exception is passed.
It might be interested later to use suppressed exceptions.