Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create onCancellation() groups for Uni and Multi #226

Merged
merged 4 commits into from Jul 23, 2020
Merged

Create onCancellation() groups for Uni and Multi #226

merged 4 commits into from Jul 23, 2020

Conversation

jponge
Copy link
Member

@jponge jponge commented Jul 23, 2020 •
edited

Fix for #221

  • Move uni.on().cancellation() to uni.onCancellation()
  • Move multi.on().cancellation() to multi.onCancellation()
  • Documentation update for multi.onCancellation()

@jponge
Move uni.on().cancellation() to uni.onCancellation()
de8f751 
Relates to #221

Signed-off-by: Julien Ponge <jponge@redhat.com>
@jponge
Move multi.on().cancellation() to multi.onCancellation()
dbdb71b 
Relates to #221

Signed-off-by: Julien Ponge <jponge@redhat.com>
@jponge
Documentation update for multi.onCancellation()
931c6b3 
Relates to #221

Signed-off-by: Julien Ponge <jponge@redhat.com>
@jponge jponge added the enhancement New feature or request label Jul 23, 2020
@jponge jponge added this to the 0.8.0 milestone Jul 23, 2020
@jponge jponge requested a review from cescoffier July 23, 2020 15:25
cescoffier
cescoffier requested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss a bit of javadoc, but the rest looks good

implementation/src/main/java/io/smallrye/mutiny/groups/MultiOnCancel.java Show resolved Hide resolved
implementation/src/main/java/io/smallrye/mutiny/groups/MultiOnCancel.java Show resolved Hide resolved
implementation/src/main/java/io/smallrye/mutiny/groups/UniOnCancel.java Show resolved Hide resolved
implementation/src/main/java/io/smallrye/mutiny/groups/UniOnCancel.java Show resolved Hide resolved
implementation/src/main/java/io/smallrye/mutiny/groups/UniOnCancel.java Show resolved Hide resolved
@jponge
Copy link
Member Author

jponge commented Jul 23, 2020

Somehow I thought I had the javadocs... adding now

@jponge jponge requested a review from cescoffier July 23, 2020 16:41
@jponge
Copy link
Member Author

jponge commented Jul 23, 2020

There you go

@jponge
Adding forgotten javadocs
4b46ef7 
Signed-off-by: Julien Ponge <jponge@redhat.com>
@jponge jponge force-pushed the feature/onCancellation-group branch from 4f8a7d7 to 4b46ef7 Compare July 23, 2020 16:43
@cescoffier
Copy link
Contributor

Waiting for CI, it can be merged afterwards.

@jponge
Copy link
Member Author

jponge commented Jul 23, 2020

Merging after CI, thanks @cescoffier

@jponge jponge merged commit 66e7b19 into master Jul 23, 2020
@jponge jponge deleted the feature/onCancellation-group branch July 23, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jponge @cescoffier