Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple OpenApiDocument instances, create per plugin execution #1034

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Allow multiple OpenApiDocument instances, create per plugin execution #1034

merged 1 commit into from
Feb 13, 2022

Conversation

MikeEdgar
Copy link
Member

Fixes #1019

@MikeEdgar MikeEdgar added this to the 2.1.18 milestone Jan 23, 2022
@MikeEdgar MikeEdgar force-pushed the 1019_support_multiple_documents branch from 2acd971 to 41b8b4d Compare January 26, 2022 12:58
@MikeEdgar MikeEdgar force-pushed the 1019_support_multiple_documents branch 2 times, most recently from ac90ddb to 9a2259b Compare February 8, 2022 11:30
@MikeEdgar MikeEdgar marked this pull request as ready for review February 8, 2022 11:31
phillip-kruger
phillip-kruger previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to test this in Quarkus and WF

@MikeEdgar
Copy link
Member Author

We might need to test this in Quarkus and WF

Yeah, I knew it was used downstream. In theory they should continue to use the INSTANCE static field.

@MikeEdgar MikeEdgar force-pushed the 1019_support_multiple_documents branch from 9a2259b to 15ea68b Compare February 9, 2022 11:31
@MikeEdgar
Copy link
Member Author

Merging - previous approval was dismissed from rebase on main: https://github.com/smallrye/smallrye-open-api/compare/9a2259b9eb6a0c1d71265ee18fded52ed09b395a..15ea68bfe348de05bbdfd4d166455a426a301c8a

@MikeEdgar MikeEdgar merged commit 10fba34 into smallrye:main Feb 13, 2022
@MikeEdgar MikeEdgar deleted the 1019_support_multiple_documents branch February 13, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.18
Development

Successfully merging this pull request may close these issues.

OpenAPI Schema: SROAP00001: Model already initialized in multi-threaded builds
2 participants
@MikeEdgar @phillip-kruger