Handle @APIResponseSchema without generated content
#1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
commented
Feb 15, 2022
Comment on lines
+194
to
+196
|
|
||
| if (CurrentScannerInfo.getCurrentProduces() != null && !TypeUtil.isVoid(responseType)) { | ||
| // Only generate the content if the endpoint declares an @Produces media type |
There was a problem hiding this comment.
Checking void doesn't really enable anything that couldn't be done with @APIResponse, but reduces surprises if void.class is given as the value for @APIResponseSchema and there is @Produces annotation.
MikeEdgar
force-pushed
the
1026_npe_when_produces_missing
branch
from
37cd19b
to
14bee58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026