Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new SmallRyeOpenAPI public builder API #1774

Merged
merged 6 commits into from Apr 25, 2024
Merged

Add new SmallRyeOpenAPI public builder API #1774

merged 6 commits into from Apr 25, 2024

Conversation

MikeEdgar
Copy link
Member

Closes #1762

@MikeEdgar MikeEdgar added this to the 3.11.0 milestone Mar 14, 2024
@MikeEdgar MikeEdgar mentioned this pull request Mar 14, 2024
Closed
@Azquelt
Copy link
Contributor

Azquelt commented Mar 19, 2024

I'll have a read through this, but for reference the place where we call smallrye OpenAPI in OpenLiberty is here: https://github.com/OpenLiberty/open-liberty/blob/a0f4167ee6dfad2d80a420d32ea410d4df239542/dev/io.openliberty.microprofile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/internal/ApplicationProcessor.java#L301

@MikeEdgar MikeEdgar force-pushed the builder-api branch 3 times, most recently from 776d7a2 to 88dfad2 Compare March 28, 2024 20:27
@MikeEdgar
Add new SmallRyeOpenAPI public builder API
1f0dede 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar
Adjust several tests for new API
e70cb9f 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar
Formatting, fix Maven plugin test
acd63d7 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar
Add JavaDocs for new builder API
a3e09dd 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar
Public config keys in SmallRyeOASConfig, deprecate OpenApiConstants
a933411 
Signed-off-by: Michael Edgar <michael@xlate.io>
@MikeEdgar
Move smallrye-config back to test-only dependency (core)
bda6e8d 
Signed-off-by: Michael Edgar <michael@xlate.io>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MikeEdgar MikeEdgar marked this pull request as ready for review April 24, 2024 16:50
phillip-kruger
phillip-kruger approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let get this in and roll forward. Should we do a major/minor bump ? Maybe branch the main first ?

@MikeEdgar MikeEdgar merged commit e60e1a5 into smallrye:main Apr 25, 2024
6 checks passed
@MikeEdgar MikeEdgar deleted the builder-api branch April 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Introduce more usable public API
3 participants
@MikeEdgar @Azquelt @phillip-kruger