Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set required = true in ParameterImpl::setIn when in == In.PATH #378

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Set required = true in ParameterImpl::setIn when in == In.PATH #378

merged 2 commits into from
Jun 24, 2020

Conversation

msmiths
Copy link
Contributor

@msmiths msmiths commented Jun 23, 2020

This changes simply sets the required attribute on ParameterImpl to true in the setIn method if the input argument equals In.PATH.

Resolves #372

@phillip-kruger
Copy link
Member

Thanks @MikeEdgar and @msmiths !!

@phillip-kruger phillip-kruger merged commit b317bb9 into smallrye:master Jun 24, 2020
@phillip-kruger phillip-kruger added this to the 2.0.3 milestone Jun 24, 2020
@msmiths msmiths deleted the issue-372 branch July 27, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

Request: ParameterImpl::setIn should set required = true for In.PATH
3 participants
@msmiths @phillip-kruger @MikeEdgar