Test and fix inheritance propagation of @JsonIgnoreProperties #385
Conversation
tkalmar
force-pushed
the
jsonignoreproperties
branch
from
054052d
to
0b673fb
Compare
tkalmar
force-pushed
the
jsonignoreproperties
branch
from
0b673fb
to
ca14996
Compare
|
@tkalmar , @phillip-kruger - thinking more about this issue, I am wondering if a better approach would be to check whether the properties are ignored in the |
|
This is where I landed: MikeEdgar@8cb217c, which seems to work with @tkalmar's original test case in the TCK project. I haven't incorporated the test changes from this PR, however. I can cherry pick the test changes from this PR if this seems like the correct approach. |
Checked your branch against my tests, works as expected. So feel free to cherry pick them if needet/wanted |
Conflicts: core/src/main/java/io/smallrye/openapi/runtime/scanner/dataobject/IgnoreResolver.java
|
@tkalmar - I've applied your commit to my branch and made a few updates based on your feedback. If you don't mind, I will go ahead and push it to your |
|
@MikeEdgar LGTM |
MikeEdgar
force-pushed
the
jsonignoreproperties
branch
from
ca14996
to
7f8b00f
Compare
There was a problem hiding this comment.
Approved. Since I added some changes here also, do you want to give it a look @phillip-kruger ?
After fixing #374 a colleague pointed out, that this fix isn't working. So i sat down and analyzed the problem. Only investigating the superclass isnt sufficient one has to inspect the whole class hierarchy to get the same behaviour as jackson. I ensured the upstreambehaviour with an test and fixed the missing ascension up the inheritance tree.
I can leave out the upstream behaviuor test, but i think it is saver to get an notice if upstream changes behaviour.