Use nested type param names in schema name, resolve types earlier #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egorklimov - this pull request includes the commit you authored and referenced in #388. Please confirm that is not a problem. |
- Adjust test expectations to align with schema type name changes
MikeEdgar
force-pushed
the
388_parameterized_type_name_derivation
branch
from
408599b
to
e78401f
Compare
|
@phillip-kruger - this is ready for review, but I was thinking we should wait to merge until we hear back from @egorklimov regarding his potential contribution. Perhaps we can do a release after this change also. |
|
Wow, thank you ;) I could rename the endpoint ("/noo...") from test, if you want, also I changed the generic type boundary in |
|
@egorklimov - I think those things are all fine (the names and boundaries). |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
Creating this PR as a draft so it can be re-based after the other open PRs. The changes here impact the naming of schemas under
#/components/schemas/...- not sure if that merits a bump to the minor version or not.