Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of Optional with array schema types #810

Merged
merged 1 commit into from
May 29, 2021
Merged

Improve handling of Optional with array schema types #810

merged 1 commit into from
May 29, 2021

Conversation

MikeEdgar
Copy link
Member

Fixes #809

@MikeEdgar MikeEdgar added this to the 2.1.5 milestone May 28, 2021
@MikeEdgar
Copy link
Member Author

@matlach - the optional types are not being properly unwrapped. This change should fix the incorrect schema you reported in #809 .

matlach
matlach approved these changes May 28, 2021
View reviewed changes
Copy link

@matlach matlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me, thank you so much for being so quick to address this issue.

phillip-kruger
phillip-kruger approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeEdgar

@phillip-kruger phillip-kruger merged commit 570d1bb into smallrye:main May 29, 2021
@MikeEdgar MikeEdgar deleted the 809_optional_array_types branch May 29, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matlach matlach matlach approved these changes

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.5
Development

Successfully merging this pull request may close these issues.

Optional of List does not generate proper schema ref
3 participants
@MikeEdgar @matlach @phillip-kruger