Disable non-public properties, rather than private #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the private-properties.enable config property to enable or disable non-public properties, rather than just private ones.
Azquelt
force-pushed
the
ignore-non-public-properties
branch
from
5da34fd
to
48a00da
Compare
|
The build check failed to download an artifact from maven central, repushed to prompt it to have another go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the private-properties.enable config property to enable or
disable non-public properties, rather than just private ones.
Fixes #825
There wasn't much feedback on the issue so I've gone ahead and created this PR which changes the meaning of
private-properties.enableto affect all non-public properties. Let me know if you'd prefer this was fixed in a different way, e.g. by introducing separate properties to configure protected or package scoped properties.