Use type: string with format: binary for InputStream and byte[]
#871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
force-pushed
the
857_binary_format_string_defaults
branch
2 times, most recently
from
1e2e740
to
eeddf04
Compare
MikeEdgar
force-pushed
the
857_binary_format_string_defaults
branch
from
eeddf04
to
914210c
Compare
|
@phillip-kruger - added another commit with a change to skip the default type attributes if a |
phillip-kruger
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #857, I realized that we are not supporting the
binarystring format (https://swagger.io/specification/#data-types). @phillip-kruger, does this seem reasonable? The change is to defaultInputStreamandbyte[]to be strings of formatbinary. As mentioned in that issue, I'm don't think thatFilecan be used for JAX-RS.