Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for #896 #899

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Added tests for #896 #899

merged 2 commits into from
Sep 3, 2021

Conversation

phillip-kruger
Copy link
Member

Signed-off-by:Phillip Kruger phillip.kruger@gmail.com

Signed-off-by:Phillip Kruger <phillip.kruger@gmail.com>
MikeEdgar
MikeEdgar previously approved these changes Sep 3, 2021
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillip-kruger - these specifically test the un-annotated parameter with @Path on the method, right?

@phillip-kruger
Copy link
Member Author

Yes, I am adding one more test with returning Response, so that it is exactly like the bug report

@phillip-kruger phillip-kruger marked this pull request as draft September 3, 2021 10:00
Signed-off-by:Phillip Kruger <phillip.kruger@gmail.com>
@phillip-kruger
Copy link
Member Author

Ok now we have a test exactly like the bug report. So this seems to be an issue in Quarkus ?!? I am going to add some tests there to see

@phillip-kruger phillip-kruger added this to the 2.1.11 milestone Sep 3, 2021
@phillip-kruger phillip-kruger merged commit 335a5d1 into smallrye:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants