-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial implementation #4
Conversation
d6fad35
to
3eb41c6
Compare
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
3eb41c6
to
8f261e1
Compare
One TCK which invokes async resource is failing https://github.com/eclipse/microprofile-opentracing/blob/master/tck/src/main/java/org/eclipse/microprofile/opentracing/tck/application/TestServerWebServices.java#L208. It fails because server span is not finished. It should be finished in @kenfinnigan @mkouba do you know why the |
Is there a way to find out in filter that async request has been completed? |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay Hm, is the filter registered successfully? |
It is, otherwise, other TCKs would fail. |
Just referencing ML discussions related to the failing TCK, at the moment without resolution: |
Based on the discussion on ML, there seems to be a bug in the undertow. @mkouba @kenfinnigan to unblock work on this I would just temporarily skip this one test and track the progress in a separate issue. |
@pavolloffay +1; just exclude the test in |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Done, #5, the link is also in the comment in Can somebody review/approve? |
Initial implementation.
Signed-off-by: Pavol Loffay ploffay@redhat.com