Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation #4

Merged
merged 4 commits into from
Jul 17, 2018
Merged

Conversation

pavolloffay
Copy link
Contributor

@pavolloffay pavolloffay commented Jul 9, 2018

Initial implementation.

Signed-off-by: Pavol Loffay ploffay@redhat.com

@pavolloffay pavolloffay force-pushed the initial-impl branch 2 times, most recently from d6fad35 to 3eb41c6 Compare July 10, 2018 13:14
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Contributor Author

pavolloffay commented Jul 10, 2018

One TCK which invokes async resource is failing https://github.com/eclipse/microprofile-opentracing/blob/master/tck/src/main/java/org/eclipse/microprofile/opentracing/tck/application/TestServerWebServices.java#L208.

It fails because server span is not finished. It should be finished in AsyncListener https://github.com/opentracing-contrib/java-jaxrs/blob/master/opentracing-jaxrs2/src/main/java/io/opentracing/contrib/jaxrs2/server/SpanFinishingFilter.java#L68. However, the AsyncListener is never invoked. The TCK was passing in Swarm correctly.

@kenfinnigan @mkouba do you know why the AsyncListener is not invoked? Can you point somebody from resteasy/undertow who might help?

@pavolloffay
Copy link
Contributor Author

Is there a way to find out in filter that async request has been completed?
Is there a way to have a globally registered AsyncListener or some completion callbak?

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@mkouba
Copy link

mkouba commented Jul 11, 2018

@pavolloffay Hm, is the filter registered successfully?

@pavolloffay
Copy link
Contributor Author

It is, otherwise, other TCKs would fail.

@pavolloffay
Copy link
Contributor Author

@pavolloffay
Copy link
Contributor Author

Based on the discussion on ML, there seems to be a bug in the undertow.

@mkouba @kenfinnigan to unblock work on this I would just temporarily skip this one test and track the progress in a separate issue.

@mkouba
Copy link

mkouba commented Jul 17, 2018

@pavolloffay +1; just exclude the test in tck-suite.xml and create a new github issue.

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay changed the title WIP: Add initial implementation Add initial implementation Jul 17, 2018
@pavolloffay
Copy link
Contributor Author

Done, #5, the link is also in the comment in tck-suite.xml.

Can somebody review/approve?

@pavolloffay pavolloffay merged commit d41fee1 into smallrye:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants