Add configuration 'retain' property for outgoing MQTT message #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the test, you need to start the consumer after the message has been produced. The best way to ensure that is to consume it once and check that retained flag is false, and then consume it again to check that retained flag is true. |
|
The code change looks good, but yes, the test might be a bit brittle. |
ozangunalp
force-pushed
the
2663-add-mqtt-outgoing-retain-config
branch
from
6c32455
to
3f1bb22
Compare
|
@diversit I pushed a fix to the test you've added. Note that only the last message is retained with mqtt. |
…QTT message. Note: test fails due to retain property not being received while it _is_ being send.
ozangunalp
force-pushed
the
2663-add-mqtt-outgoing-retain-config
branch
from
3f1bb22
to
518f948
Compare
ozangunalp
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #2663
I did not find any documentation or example to update manually.
As far as I can see, the documentation gets updated automagically with the new connector attribute for outgoing messages.
Added a test to verify the send message contains the 'retain' property set to True, but cannot get this test to succeed.
It seems to go wrong somewhere in the Mqtt client code.
While debugging, I see the retain property is correctly set to true when the message is transformed into a
byte[].But when reconstructing the message from
byte[]the retain setting seems to have been lost and therefore the value is False instead of the expected True.Any idea how to fix this? I'm clueless.