Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦈 add resolve-srv option 🦈 #549

Merged
merged 1 commit into from
May 22, 2023
Merged

🦈 add resolve-srv option 🦈 #549

merged 1 commit into from
May 22, 2023

Conversation

eformat
Copy link
Contributor

@eformat eformat commented May 7, 2023 •
edited
Loading

WIP - fixes #548

  • need to add some tests
  • add to docs

@cescoffier
Copy link
Contributor

Nice!

@eformat eformat marked this pull request as ready for review May 9, 2023 22:49
@eformat
Copy link
Contributor Author

eformat commented May 9, 2023

added Tests and Doco
cc: @cescoffier

@cescoffier cescoffier added the enhancement Enhancements or Request for enhancement label May 14, 2023
@cescoffier cescoffier added this to the 2.3.0 milestone May 14, 2023
@cescoffier
Copy link
Contributor

@eformat I've (force) pushed a few changes:

  • revapi justification
  • make the test a bit more robust

Let's see what the CI says, but I think it's good to go.

@cescoffier cescoffier merged commit c14bb4d into smallrye:main May 22, 2023
8 checks passed
@cescoffier
Copy link
Contributor

Thanks!

@eformat
Copy link
Contributor Author

eformat commented May 22, 2023

thanks @cescoffier 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
enhancement Enhancements or Request for enhancement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Allow DNS SRV skip resolve
2 participants
@eformat @cescoffier