Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the use of the --redirect-url flag #511

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Clarify the use of the --redirect-url flag #511

merged 1 commit into from
Jul 21, 2021

Conversation

maraino
Copy link
Collaborator

@maraino maraino commented Jul 21, 2021

Description

This PR changes the usage of the --redirect-url. This flag is used in the step oauth command and can also be used in the step ca bootstrap command to write it in the defaults.json file.

This flag won't have any effect on oob flows, but we cannot fail if both are used because it will cause errors on specific configurations where errors are not expected.

Fixes #510

This change changes the usage of the --redirect-url. This flag is
used in the `step oauth` command and can also be used in the
`step bootstrap` command to write it in the defaults.json file.

This flag won't have any effect on oob flows, but we cannot fail
if both are used because it will cause errors on specific configurations
where errors are not expected.

Fixes #510
@maraino maraino requested a review from dopey July 21, 2021 18:45
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 21, 2021
@maraino maraino removed the needs triage Waiting for discussion / prioritization by team label Jul 21, 2021
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraino maraino merged commit 8da5a5d into master Jul 21, 2021
@maraino maraino deleted the redirect-url branch July 21, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants