Fix invalid return type on unknown glyph (#459)

* Fix invalid return type on unknown glyphs * Fix invalid return type on unknown glyphs * Fix invalid return type on unknown glyphs * Fix invalid return type on unknown glyphs * Don't call assert statically as per the current project standard * Remove coverage annotation as it is currently not used in this project Co-authored-by: prinsfrank <frank@superscanner.nl>
smalot · Oct 1, 2021 · 5ed3040 · 5ed3040
1 parent ba3f039
commit 5ed3040
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 5 deletions.
diff --git a/src/Smalot/PdfParser/Encoding.php b/src/Smalot/PdfParser/Encoding.php
@@ -110,7 +110,7 @@ public function getDetails(bool $deep = true): array
         return $details;
     }
 
-    public function translateChar($dec): int
+    public function translateChar($dec): ?int
     {
         if (isset($this->mapping[$dec])) {
             $dec = $this->mapping[$dec];

diff --git a/src/Smalot/PdfParser/Encoding/PostScriptGlyphs.php b/src/Smalot/PdfParser/Encoding/PostScriptGlyphs.php
@@ -1084,14 +1084,14 @@ public static function getGlyphs(): array
         ];
     }
 
-    public static function getCodePoint($glyph)
+    public static function getCodePoint($glyph): ?int
     {
         $glyphsMap = static::getGlyphs();
 
         if (isset($glyphsMap[$glyph])) {
             return hexdec($glyphsMap[$glyph]);
         }
 
-        return $glyph;
+        return null;
     }
 }
diff --git a/src/Smalot/PdfParser/Font.php b/src/Smalot/PdfParser/Font.php
@@ -428,15 +428,15 @@ public function decodeContent(string $text, ?bool &$unicode = null): string
                 foreach ($chars as $char) {
                     $dec_av = hexdec(bin2hex($char));
                     $dec_ap = $encoding->translateChar($dec_av);
-                    $result .= self::uchr($dec_ap);
+                    $result .= self::uchr($dec_ap ?? $dec_av);
                 }
             } else {
                 $length = \strlen($text);
 
                 for ($i = 0; $i < $length; ++$i) {
                     $dec_av = hexdec(bin2hex($text[$i]));
                     $dec_ap = $encoding->translateChar($dec_av);
-                    $result .= self::uchr($dec_ap);
+                    $result .= self::uchr($dec_ap ?? $dec_av);
                 }
             }
             $text = $result;

diff --git a/tests/Unit/EncodingTest.php b/tests/Unit/EncodingTest.php
@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Smalot\PdfParser\Unit;
+
+use Smalot\PdfParser\Document;
+use Smalot\PdfParser\Encoding;
+use Tests\Smalot\PdfParser\TestCase;
+
+class EncodingTest extends TestCase
+{
+    public function testTranslateCharOnUnknownGlyph(): void
+    {
+        $encoding = new Encoding(new Document());
+
+        $this->assertNull($encoding->translateChar('foo'));
+    }
+}