Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a new release be tagged? #465

Closed
PrinsFrank opened this issue Oct 8, 2021 · 3 comments
Closed

Can a new release be tagged? #465

PrinsFrank opened this issue Oct 8, 2021 · 3 comments

Comments

@PrinsFrank
Copy link
Contributor

@k00ni There are some bugfixes that are unreleased. Can a new release be tagged so everyone can use them?

@k00ni
Copy link
Collaborator

k00ni commented Oct 11, 2021

I am hesitant because we merged #440 which changes parameter and return types. Following Semantic Version would mean that we bump major version from 1 to 2. But almost all code changes are behind the scene, therefore developers shouldn't notice it.

I am in favor of the practical way and just go with it. My proposal: make a release candidate and create an issue to call for testers. Hopefully we get enough feedback to find remaining problems related to these changes.

What do you think?

CC @j0k3r @smalot @izabala @rubenvanerk

@izabala
Copy link
Contributor

izabala commented Oct 14, 2021

Sorry, I didnt catch that. What is needed to be tested?

@k00ni
Copy link
Collaborator

k00ni commented Oct 15, 2021

I created a new issue with further information: #468

@k00ni k00ni closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants