Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for testers: Please test our latest release candidate v1.2.0-RC2 #468

Closed
k00ni opened this issue Oct 15, 2021 · 8 comments
Closed

Call for testers: Please test our latest release candidate v1.2.0-RC2 #468

k00ni opened this issue Oct 15, 2021 · 8 comments

Comments

@k00ni
Copy link
Collaborator

k00ni commented Oct 15, 2021

What is going on?

Currently we have the situation that this library grows slowly but steady with mostly foreign contributions. I opened this issue because we merged #440 and #459. Both added explicit parameter and return types. We follow Semantic Versioning and are required to increase major version, but in my opinion almost all of these changes were internally. Because of our limited time resources I decided to try middle way: release it regardless of possible backward compatibility breaks, but mark it as a release candidate and include the community to see if there are problems left.

How can you help?

It would be great if some of you could lend us a hand and test our latest release candidate:

https://github.com/smalot/pdfparser/releases/tag/v1.2.0-RC2

Just do the things you normally do with the library and check if problems occur. If you get errors, please post a comment here with a basic description, error message and if possible the PDF you used. If everything works as expected, please up vote this issue. This way there is some orientation for us.

Thank you for your help!

Ref #465

CC @PrinsFrank @j0k3r @smalot @izabala


FAQ

Question Do I have to use the zip file as it is in https://github.com/smalot/pdfparser/releases, or we will use a branch or a pull request for this?
Answer You can use the way you prefer (composer, download ZIP, ...). If you find any errors/issues please create a pull request against master branch.

@izabala
Copy link
Contributor

izabala commented Oct 15, 2021

@k00ni, I soon as we finished with pull request #455, I may give a hand with this. I am busy, but I could spend a little time each day to test it.
One question do I have to use the zip file as it is in https://github.com/smalot/pdfparser/releases/tag/v1.2.0-RC1, or we will use a branch or a pull request for this? (Just to see how to work on this).

@PrinsFrank
Copy link
Contributor

PrinsFrank commented Oct 15, 2021

We have been running the master branch and subsequent forked branches with fixes for typeErrors on production for over a month now since we needed @Nickmanbear 's fix in #457 , and all my recent PRs are a result of bugs we encountered related to the recent types change. I don't think we use every functionality of this package, but parse quite a variety of different kinds of pdfs.

We have seen some more silently failing parse attempts recently. Wether those are due to recursion, them being very large files (hundreds of megabytes), because of the type changes or because we are watching more closely I am not sure yet. I am currently unavailable due to a broken hand and being sick, but hopefully will be able to provide more info in the upcoming week. I will keep you guys updated.

Btw: We are currently using the branch of #466 which has another typeError fix.

@k00ni
Copy link
Collaborator Author

k00ni commented Oct 18, 2021

Update 18th Oct. 2021

Merged:

New release: 1.2.0-RC2

https://github.com/smalot/pdfparser/releases/tag/v1.2.0-RC2


Thank you for your quick replies.

@izabala wrote:

One question do I have to use the zip file as it is in https://github.com/smalot/pdfparser/releases/tag/v1.2.0-RC1, or we will use a branch or a pull request for this?

I updated my initial post with this question and an answer.

@izabala wrote:

I soon as we finished with pull request #455, I may give a hand with this. I am busy, but I could spend a little time each day to test it.

That sounds great. I merged #455 to speed this up.

@PrinsFrank:

[..] and all my recent PRs are a result of bugs we encountered related to the recent types change. We have seen some more silently failing parse attempts recently. Whether those are due to recursion, them being very large files (hundreds of megabytes), because of the type changes or because we are watching more closely I am not sure yet.

That sounds worrisome, but its a good thing we have you guys taking a look also. Looking forward to your feedback.

Btw. all the best with your hand!

@k00ni k00ni pinned this issue Oct 18, 2021
@k00ni k00ni changed the title Call for testers: Please test our latest release candidate v1.2.0-RC1 Call for testers: Please test our latest release candidate v1.2.0-RC2 Oct 18, 2021
@izabala
Copy link
Contributor

izabala commented Oct 18, 2021

@k00ni I expended almost all the day on testing with Pdf files I work with. Using the V1.2.0-RC2. I used more the getDataTM, getTextXY related methods, for parsing, that are the methods I use more, on the files I work with. Everything work fine for me.

@PrinsFrank
Copy link
Contributor

I was able to spend some time on this, and our issues with failing parse attempts were caused by a bug in our own code. As we don't have any more problems with the package itself I think it is ready for release!

@k00ni
Copy link
Collaborator Author

k00ni commented Oct 20, 2021

Thank you guys for your effort and fast response!

@k00ni
Copy link
Collaborator Author

k00ni commented Nov 1, 2021

Small update: We currently received feedback from two people. I would like to keep this open for around 7-10 days. If there aren't any errors reported I will release 1.2.0.

@k00ni k00ni mentioned this issue Nov 16, 2021
@k00ni
Copy link
Collaborator Author

k00ni commented Nov 16, 2021

Replaced by #480

Thank you for your time though!

@k00ni k00ni closed this as completed Nov 16, 2021
@k00ni k00ni unpinned this issue Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants