Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes latest coding style and PHPStan issues #563

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Conversation

k00ni
Copy link
Collaborator

@k00ni k00ni commented Nov 25, 2022

We got many pull requests lately. Because all of them have to fix coding style issues to pass tests, I decided to fix them separately. This way we can reduce each PR and don't pollute them.

To the authors of the new PR's @alesrebec, @DogLoc and @oliver681: After this PR was approved I will merge it into master branch right away. Please merge in master branch int your PR afterwards. Thank you.

@k00ni k00ni added the fix label Nov 25, 2022
@k00ni k00ni requested a review from j0k3r November 25, 2022 15:34
@k00ni k00ni self-assigned this Nov 25, 2022
@j0k3r
Copy link
Collaborator

j0k3r commented Nov 25, 2022

You now need to fix PHPStan issues as well :)

@k00ni k00ni changed the title Fixes latest coding style issues Fixes latest coding style and PHPStan issues Nov 25, 2022
@k00ni
Copy link
Collaborator Author

k00ni commented Nov 25, 2022

Hahaha, just did 😄

@k00ni k00ni requested review from j0k3r and removed request for j0k3r November 25, 2022 15:51
@k00ni k00ni merged commit 13a8178 into master Nov 25, 2022
@k00ni k00ni deleted the fix/coding-style-issues branch November 25, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants