-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pn 27 reliable receiving in gcm #104
Conversation
Small store refactoring
|
||
gcmMessage := gcm.NewMessage(payload, gcmID) | ||
logger.WithFields(log.Fields{ | ||
"gcm_id": gcmID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use CamelCase in logs
server/message_for_route_test.go:10: undefined: MessageForRoute This is causing your build to fail |
…reliable-receiving-in-gcm
bufferSize = 1000 | ||
) | ||
|
||
var logger = log.WithField("module", "gcm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var logger = log.WithFields(log.Fields{
"app": "guble",
"module": "gcm",
"env": "TBD",
})
this is the common usage
sender: sendMessageSample, | ||
} | ||
params.throughputSend() | ||
fmt.Println(params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why yse fmt.Println and not log ?
No description provided.