-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GalleryPlugin.on_page_content() crashing when page.edit_url is None #32
Comments
…mkdocs.yml. Fix issue smarie#32
By the way, why did you want to disable the "edit uri" option ? Just being curious |
At work we're hosting the project's documentation on an internal Apache web server, and I was not sure that the 'edit' link would work as expected. Seems to me that the edit capability is tightly linked to the services provided by the hosting platform. For example, on Github, clicking on 'Edit this page' opens a page mentioning that "Submitting a change will write it to a new branch in your fork ...". But if you have any idea on how to enable such editing capabilities in a simple way, that would certainly be useful for us! I must however confess I did not spend much time looking for additional details in MkDocs or Materials documentation pages. |
Indeed
Please let me know if you try - I'd be interested to know if the modification of edit uri that I do on the gallery pages is compliant with this scenario |
This happens when the "edit_uri" parameter is set to an empty string, as advised in MkDocs documentation when one does not want any "edit URL link" displayed on the documentation pages.
The text was updated successfully, but these errors were encountered: