-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various problems - main one was systematic execution of .py scripts, regardless of md5 hash check #27
Conversation
…elative - '.' for instance - project_root2 is inevitably different.
Thanks a lot @mchaaler ! Very nice I see three things in this PR:
Can you please create one issue for each of these bullet points, so that we can relate the PR ? We can keep this single PR fixing the 3 at once. In particular I do not understand how the thumbnail resolution fix I see in the PR, relates to the title in this PR (python scripts being re-run even if the md5 hash is the same). Can you please elaborate ? Thanks in advance ! |
Hi! Considering the extra resolve() statements added in 4896676, I need to dig further. I am not able to reproduce the bug at home so far (worked on it from the office), although the platforms are similar (Windows 10/11, PyCharm & Git-bash or fish, conda virtual environment). The use cases are different though: working on mkdocs-gallery itself at home, on a business project at work. |
I think I got it. Just added a commit to the PR that fixes issue #32, and reverted 4896676. |
All set, thanks @mchaaler ! |
Since I'm not confident enough with tests, I did not add the corresponding non-regression tests. Eager to learn by looking at how you'll implemented them!
EDIT:
Fixes #28
Fixes #29
Fixes #32