Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize setup.py a bit #44

Merged
merged 2 commits into from
Sep 24, 2019
Merged

modernize setup.py a bit #44

merged 2 commits into from
Sep 24, 2019

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Aug 9, 2019

  • use pyproject.toml so that build deps can be installed with pip instead of easy_install
    (setup_requires is effectively deprecated by PEP 518)
  • pypandoc is no longer required for markdown long_description,
    as PyPI supports markdown via long_description_content_type

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files          14       14           
  Lines         990      990           
=======================================
  Hits          849      849           
  Misses        141      141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ed325...9a84e47. Read the comment docs.

PyPI supports markdown if long_description_content_type is specified
because pip ignores setup_requires, these dependencies will be installed with easy_install
@smarie
Copy link
Owner

smarie commented Sep 1, 2019

Thanks for this PR ! Sorry I was away for a few weeks.

EDIT
I was not familiar with pyproject.toml but after reading a few articles about it I am not sure that I wish to take position in favor of PEP518 too soon here. Let's wait for the landscape and tools to stabilize a bit.

So could you please revert this part and just leave the long_description markdown simplification ? I'll be happy to merge then. Thanks!

@smarie
Copy link
Owner

smarie commented Sep 24, 2019

Afterthought: I'll merge "as is" so that at least on one library I have a reference on how it is recommended to do with the toml. Thanks again!

@smarie smarie merged commit 028058d into smarie:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants