This change makes bcrypt_nif thread safe #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix a leak of a 64 bytes binary per call to bcrypt_nif:gen_salt |
|
Hi @russor, thank you for the contribution and apologies for the delay in getting back to you. The first part is taken care of by 645b00e (originally chef@645b00e) now. The memory leak patch I cherry-picked and pushed to master as 1039875, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it, multiple threads calling to bcrypt_nif can result in bad hashes coming back. If you're lucky, you'll get nulls in unexpected places and attempts to verify the hash will get a bcrypt failure; if you're not, you'll get a syntactically valid but incorrect hash back.
I'm using bcyrpt_nif directly, not using the worker interface. If you're using the worker interface you should be OK, because it only does one bcrypt at a time.