Pass the correct value for merge_when_pipeline_succeeds #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing this value as True makes gitlab assume that the MR must have a pipeline, which means if it's doesn't, then the MR will be denied. Instead we should use the value of project.only_merge_if_pipeline_succeeds, As this will mean the gitlab logic will be correct: If the MR requires a pipeline to merge then we'll only merge if a pipeline succeeds If the MR doesn't needs a pipeline to succeed (i.e. has this setting on the project off) then we won't pass the parameter and hence the merge will be allowed Fixes issue smarkets#240
JaimeLennox
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing this value as True makes gitlab assume that the MR must have
a pipeline, which means if it's doesn't, then the MR will be denied.
Instead we should use the value of project.only_merge_if_pipeline_succeeds,
As this will mean the gitlab logic will be correct:
If the MR requires a pipeline to merge then we'll only merge if a pipeline
succeeds
If the MR doesn't needs a pipeline to succeed (i.e. has this setting on the
project off) then we won't pass the parameter and hence the merge will be allowed
Fixes issue #240