Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider warmup setting when loading data #116

Merged
merged 3 commits into from Apr 24, 2019
Merged

Consider warmup setting when loading data #116

merged 3 commits into from Apr 24, 2019

Conversation

smarr
Copy link
Owner

@smarr smarr commented Apr 23, 2019

When we load data from the data file, we also need to apply the warmup setting to make sure that we get the same statistics as during initial execution.

This fixes #111.

@smarr
Added missing license header
2b747c4 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Added test to confirm issue
63120bb 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Consider warmup for loaded data, too
977c170 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr smarr added the Bug label Apr 23, 2019
@smarr smarr added this to the v1.0 - Foundation milestone Apr 23, 2019
@smarr smarr self-assigned this Apr 23, 2019
@smarr smarr mentioned this pull request Apr 23, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 85.933% when pulling 977c170 on issue-111-warmup-ignored into 4b81ee1 on master.

@smarr smarr merged commit 23a3b33 into master Apr 24, 2019
@smarr smarr deleted the issue-111-warmup-ignored branch April 24, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarr smarr

Labels
Bug
Projects
Usability
Status: Done
Milestone
v1.0 - Foundation
Development

Successfully merging this pull request may close these issues.

unexpected semantics of warmup configuration
2 participants
@smarr @coveralls