Suppress error output when used outside of git repo #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
changed the title
git ls-remote --get-urlgit ls-remote --get-url
|
@cmccandless thanks a lot for the PR! :) However, I think this is likely going to be a little more effort. And, we need to find a way to make this robust enough for Python 2.7 and Python 3, where tests are currently failing. |
|
Build failed because it couldn't push to Coveralls. The tests passed. |
Let’s be slightly more conservative. This avoids shelling out to git when we know it’s not a repo. Avoids too much dependency on git behavior that may change between versions. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
approved these changes
Oct 1, 2020
|
I pushed one more commit to handle the case outside of a repo more explicit. @cmccandless thanks for the PR! |
smarr
changed the title
git ls-remote --get-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #152