Fix data transmission to ReBenchDB on timeout #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- also make retry wait a little because we likely got a timeout Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Python 3 support, a bug sneaked in unnoticed.
While the initial HTTP request would use the data encoded as UTF-8 bytes, the retry after a timeout would use the original data string.
Didn't fix a parameter there.
After tracking it down, and fixing it, I refactored the code a little further, put it into a loop, and added a backoff to handle timeouts more gracefully.
The issue with ReBenchDB is that my server is just a little too busy, and the HTTP server had a rather tiny timeout.
The timeout got increased, but, the server is still busy, so...
Unrelated, this PR also adds a test to make sure that denoise has the expected interface.