Give the build commands the env of run_id #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumption here is that the build needs some environment, which may have been defined for the executor or suite. Though, there’s a risk that the env is contaminated for a specific run. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build scripts may need some environment, which may have been defined for the executor or suite.
The current use case is as simple as having a
Makefilethat needs to be able to access utils on the standard PATH.The current solution takes the environment from the
run_id, and there’s a risk that this env might be contaminated/be specific to the run. Though, for now, it's good enough. And if it turns out to be problematic, we can fix it later.@tolauwae this is for you. It should fix your immediate issue of not being able to specify any environment.
This PR is an extension of #174.