Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document gauge adapter expected output formats #197

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

raehik
Copy link
Contributor

@raehik raehik commented Dec 7, 2022

Related to #186 . Some gauge adapters are intended to be plug-and-play, supporting common benchmark formats. PlainSecondsLog and ReBenchLog are custom and deserve some detail on the output format they expect.

@smarr
Copy link
Owner

smarr commented Dec 7, 2022

Hi @raehik thanks for this, greatly appreciated. Just to set expectations, I fear I won't get to giving this any thought before the end of the year or early next year.

Sorry

@smarr
Copy link
Owner

smarr commented Jan 3, 2023

@raehik thanks again, I am now looking at this and would like to add on a few other changes.

Could you "allow edits from maintainers"?
There should be a check box on the right for this. See for instance https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@smarr
Copy link
Owner

smarr commented Jan 3, 2023

As a preview, with my changes, the docs would look like this: https://rebench.readthedocs.io/en/docs-reorg/extensions/

(In a just merged commit, I also changed the theme, the top navigation bar was often over the text, which wasn't great)

@raehik
Copy link
Contributor Author

raehik commented Jan 12, 2023

This was strangely hard to troubleshoot, but looks like I can't because the fork is on a GitHub org (thread)... let me move this PR to a personal fork instead.

@smarr
Copy link
Owner

smarr commented Jan 12, 2023

Our you could just pull or cherry pick my change from the branch :)

@smarr
Copy link
Owner

smarr commented Jan 12, 2023

…tput and more details

Signed-off-by: Stefan Marr <git@stefan-marr.de>
@raehik raehik marked this pull request as ready for review January 12, 2023 12:42
@raehik
Copy link
Contributor Author

raehik commented Jan 12, 2023

Good point! Done & removed draft tag.

@smarr smarr merged commit 08c736b into smarr:master Jan 12, 2023
@smarr
Copy link
Owner

smarr commented Jan 12, 2023

And merged. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants