Use JOIN ... USING instead of JOIN ... ON #185
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a PR to move from using JOIN ... ON to the JOIN ... USING, which only requires to name the columns on which to join.
Though, while I do like the idea of getting rid of columns just named
id
, I don't like that the JOIN clauses don't make it explicit which tables are actually joined. While this makes things somewhat redundant, it also allows one to read an SQL query in isolation and see which tables are linked together.So, this PR is mostly for archival.
I'll close it without merging. (It's also still incomplete).