Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stepping, and code consistency #152

Merged
merged 4 commits into from
May 11, 2017
Merged

Conversation

smarr
Copy link
Owner

@smarr smarr commented May 11, 2017

  • message ids shouldn't be -1, causes problems with the frontend
  • fix #join operations skipping top two stack frames, was a copy'n'paste mistake
  • refactor debugging related code to be in the Tracing* activities
  • use default methods on Activity interface for code reuse

smarr added 4 commits May 11, 2017 11:38
It confuses the assertion in the frontend.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
This was a copy and paste mistake.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- also use default methods on Activity where possible

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr smarr added bug Fixes an issue, incorrect implementation enhancement Improves the implementation with something noteworthy labels May 11, 2017
@smarr smarr added this to the v0.4.0 milestone May 11, 2017
@smarr smarr merged commit c39b60b into master May 11, 2017
@smarr smarr deleted the activity-default-methods branch May 11, 2017 09:54
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2e576d9 on activity-default-methods into ** on master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes an issue, incorrect implementation enhancement Improves the implementation with something noteworthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants