Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set promise data fields to null on resolution #300

Merged
merged 1 commit into from Jul 3, 2019

Conversation

1 participant
@smarr
Copy link
Owner

commented Jul 2, 2019

On resolution, we consume all the data, and the fields are no longer used, because future callbacks/messages are scheduled directly without being registered on the promise.

This fixes #294, which was essentially a memory leak.

Set promise data fields to null on resolution
On resolution, we consume all the data, and the fields are no longer used, because future callbacks/messages are scheduled directly without being registered on the promise.

Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr added the bug label Jul 2, 2019

@smarr smarr added this to the v0.7.0 milestone Jul 2, 2019

@smarr smarr added this to Open Issues in Completeness via automation Jul 2, 2019

@smarr smarr merged commit 20e8474 into dev Jul 3, 2019

4 checks passed

ci/gitlab/git.cs.kent.ac.uk Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.582%
Details

Completeness automation moved this from Open Issues to Completed Jul 3, 2019

@smarr smarr deleted the unlink-promise-data branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.