Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added benchmarks for threads&locks and STM #369

Merged
merged 6 commits into from
Aug 10, 2020
Merged

Added benchmarks for threads&locks and STM #369

merged 6 commits into from
Aug 10, 2020

Conversation

smarr
Copy link
Owner

@smarr smarr commented Aug 8, 2020 •
edited
Loading

This PR extracts the benchmarks from #337.

This is an attempt to breakup the PR in more manageable chunks for me to review.

  • deletes duplicated code for one of the benchmarks
  • makes the benchmark configuration more uniform and groups the concurrency-model related benchmarks

@smarr smarr force-pushed the da-ut-extract-benchmarks branch 5 times, most recently from fe71b86 to 5b16ca7 Compare August 9, 2020 13:39
daumayr and others added 6 commits August 9, 2020 15:39
@daumayr @smarr
Added benchmarks for threads&locks and STM
f74d8dd
@smarr
Increase benchmark run time to be suitable
5ed717f 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Don’t run CSP and Mutex tests with interpreter
2eaf339 
Saves time

Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Delete initial copy of Philosophers benchmark
58e0731 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Make benchmark configuration more uniform
8b28d4a 
- have suites from STM, CSP, and Mutex, and an SOMns-concurrency-models experiment

Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Rename benchmark suite for fork/join without concurrency to fj-seq-*
578eb54 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Copy link
Owner Author

smarr commented Aug 9, 2020

@daumayr could you please review, and check whether this is ok for you?
The commits do the steps somewhat separate, which may make reviewing easier.
The initial commit is a squashed version of what you got in #337.

@smarr smarr added the enhancement Improves the implementation with something noteworthy label Aug 9, 2020
daumayr
daumayr approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@daumayr daumayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look ok

@smarr smarr merged commit bb22fda into dev Aug 10, 2020
@smarr smarr deleted the da-ut-extract-benchmarks branch August 10, 2020 09:53
@smarr
Copy link
Owner Author

smarr commented Aug 10, 2020

Thanks. One more step to merging #337 😄

@smarr smarr mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daumayr daumayr daumayr approved these changes

Assignees
No one assigned
Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarr @daumayr