Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update aquaculture data model #3

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Feature/update aquaculture data model #3

merged 8 commits into from
Mar 1, 2022

Conversation

AHABID
Copy link
Member

@AHABID AHABID commented Dec 17, 2021

No description provided.

@albertoabellagarcia
Copy link
Contributor

Mandatory (waste of time as well point 1)
1.- please remove README.md and spec.md they are unnecessary and they will be removed when published
2.- missing notes.yaml (even empty) for customization in every data model. See template https://github.com/smart-data-models/data-models/blob/master/templates/dataModel_for_submision/notes.yaml

Recommendations with possible discussion
1.- Payloads are quite limited (same as schema.json) in terms of attributes
2.- It would be good to populate the ADOPTERS.yaml files

@albertoabellagarcia
Copy link
Contributor

Thanks @AHABID.
Do you need anything else to address these changes?

albertoabellagarcia
albertoabellagarcia reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a call for saving your time. https://doodle.com/meeting/participate/id/QeZ0Mlgb

Feed/LICENSE.md Outdated
@@ -0,0 +1,96 @@
# Creative Commons Attribution 4.0 International Public License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not necessary.

Feed/README.md Outdated
@@ -0,0 +1,40 @@
# Feed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not necessary.

Feed/doc/spec.md Outdated
@@ -0,0 +1,27 @@
Entity: Feed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not necessary.

Feed/examples/example.json
@@ -0,0 +1,7 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One property for the payload.... is not much, isn't it?

Feed/examples/example.jsonld
@@ -0,0 +1,7 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One property for the payload.... is not much, isn't it?

Sump/ADOPTERS.yaml
@@ -0,0 +1,10 @@
description: This is a compilation list of the current adopters of the data model FishContainment of the Subject dataModel.Aquaculture. All fields are non mandatory. More info at https://smart-data-models.github.io/data-models/templates/dataModel/CURRENT_ADOPTERS.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be included the use case here

Sump/LICENSE.md Outdated
@@ -0,0 +1,96 @@
# Creative Commons Attribution 4.0 International Public License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary

Sump/README.md Outdated
@@ -0,0 +1,40 @@
# Sump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary

Sump/doc/spec.md Outdated
@@ -0,0 +1,31 @@
Entity: Sump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitions here to the shcema.json according to the contribution manual pages 8 and 9

Sump/schema.json
@@ -0,0 +1,35 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing attributes used in the payloads.

albertoabellagarcia
albertoabellagarcia reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments

albertoabellagarcia
albertoabellagarcia approved these changes Mar 1, 2022
View reviewed changes
context.jsonld Outdated Show resolved Hide resolved
AHABID and others added 2 commits March 1, 2022 10:23
@AHABID
Merge branch 'feature/update-aquaculture-data-model'
051e60e 
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@AHABID
Merge branch 'master' of https://github.com/smart-data-models/dataMod…
a45f0d3 
…el.Aquaculture
@AHABID AHABID merged commit 9ad8c07 into master Mar 1, 2022
@AHABID
Copy link
Member Author

AHABID commented Mar 1, 2022

I will merge this PR since it was opened since long time, and create new one about:

  1. attributes definitions and possible alignements
  2. digital twin integration

@AHABID AHABID deleted the feature/update-aquaculture-data-model branch March 1, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertoabellagarcia albertoabellagarcia albertoabellagarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AHABID @albertoabellagarcia