Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added A2CS Data Model #26

Conversation

ts-exsensio
Copy link
Contributor

No description provided.

@albertoabellagarcia albertoabellagarcia merged commit cb1c153 into smart-data-models:master Jan 27, 2021
@albertoabellagarcia
Copy link
Contributor

  • DIH2/A2CS/OEEMetric/doc/spec.md is not necessary, however, its contents have to be located into the schema.json according to the manual contribution_manual
  • DIH2/A2CS/OEEMetric/schema.json have many required properties, it should be considered to reduce this amount
  • DIH2/A2CS/Product/doc/spec.md (same as previous spec)
  • DIH2/A2CS/Product/schema.json EntityIdentifierType is a relationship, see contribution_manual , https://github.com/ts-exsensio/DataModel/common-schema.json#/definitions/TimeSpan is a 404. some doubts if product has to be an Entity.
  • DIH2/A2CS/Station/doc/spec.md (see other spec)
  • Station is a very generic name. I guess it could be more specific.
  • DIH2/A2CS/Station/schema.json see same comments as the previous schema
  • DIH2/A2CS/common-schema.json further info why it should be necessary to include the patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants