Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include method to FHIRSearch objects #52

Merged
merged 1 commit into from
May 14, 2020

Conversation

abjonnes
Copy link
Contributor

This adds the ability to use _include and _revinclude with FHIRSearch objects (#13). It supports only simple forward or reverse includes - no recursive or iterative includes.

Also fixes a small typo in FHIRSearch (#35)!

@Bastlwastl42
Copy link

Hey there,
so i was looking for this feature which is added in this pull request and was wondering why it took so long to be included. I get the changes from @abjonnes and build my own version of fhirclient with that to test it in my application, and it works pretty well. However, i can't keep my own patched version in my application and i don't want to start the hazzle deriving everything for only a few changes required in the used fhirclient.
So please feel nudged, it would be a great help for me and my development, if these changes/this feature can find its way into a new version of fhirclient.
Best regards

@CallMeBW
Copy link

Hey,
I can only support what @Bastlwastl42 said. Having this change merged would help us a lot. Please, consider reviewing and integrating this pull request.
Regards

@hsolbrig hsolbrig merged commit 3e1e990 into smart-on-fhir:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants